Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 De-hypothesize regression test #4616

Merged
merged 1 commit into from
Aug 22, 2024

Commits on Aug 22, 2024

  1. 🎨 De-hypothesize regression test

    The original reason failures happened was because the form name was
    used to construct the file name of the PDF, which resulted in nested
    paths with forward slashes.
    
    The ambition with hypothesis was nice - whatever form name you specify
    should not result in broken file saving, but hypothesis comes up with
    some very exotic unicode characters that font libraries and/or
    weasyprint sometimes cannot handle. These edge cases are not worth
    fixing or mitigating with fancy input validating restricting the
    unicode range of valid characters, but we also do not want these
    flaky test failures.
    
    The test is rewritten without hypothesis to illustrate the original
    failure, preventing similar further regressions. If the edge cases
    do happen for real, we'll have a stakeholder funding the extra
    mitigations needed.
    sergei-maertens committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    911ec28 View commit details
    Browse the repository at this point in the history