Accessibility improvement - Descriptive postcode field error message #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4780 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 748 748
Lines 25413 25413
Branches 3358 3358
=======================================
Hits 24538 24538
Misses 610 610
Partials 265 265 ☔ View full report in Codecov by Sentry. |
robinmolen
force-pushed
the
feature/4719-accessibility-improvement-invalid-postcode-message
branch
from
baef18e
to
7fe697d
Compare
This caused the preset nested validate schema for components not to be copied over properly, leading to some accessibility issues, but probably a whole other set of problems. I suspect an editor auto-complete thing messing things up, combined with the object spread of undefined leading to an empty object rather than crashing hard lead to this bug not being detected/reported in two years.
sergei-maertens
force-pushed
the
feature/4719-accessibility-improvement-invalid-postcode-message
branch
from
7fe697d
to
88716ad
Compare
sergei-maertens
approved these changes
Nov 8, 2024
sergei-maertens
deleted the
feature/4719-accessibility-improvement-invalid-postcode-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4719
Changes
Providing postcode fields with descriptive error messages
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene