Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility improvement - Descriptive postcode field error message #4780

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Accessibility improvement - Descriptive postcode field error message #4780

merged 2 commits into from
Nov 8, 2024

Commits on Nov 8, 2024

  1. ♿ [#4719] Added expected postcode format to error message

    @robinmolen @sergei-maertens
    robinmolen authored and sergei-maertens committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d899eb6 View commit details
    Browse the repository at this point in the history

  2. 🐛 Fix type error in object spread 

    This caused the preset nested validate schema for components not to be
copied over properly, leading to some accessibility issues, but
probably a whole other set of problems.

I suspect an editor auto-complete thing messing things up, combined
with the object spread of undefined leading to an empty object rather
than crashing hard lead to this bug not being detected/reported in two
years.
    @sergei-maertens
    sergei-maertens committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    88716ad View commit details
    Browse the repository at this point in the history