Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session management updates #889

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

surbhiia
Copy link
Contributor

This PR covers the following:

@LikeTheSalad
Copy link
Contributor

Hi @surbhiia

Thank you for these changes. There's one that I think we need to review if it's needed:

Adding two separate configs for session foreground and background timeout, resolving #794

We discussed in the last SIG meeting that it's probably not a good idea to have different behaviors based on whether the app is in the "foreground" or "background", because those terms might mean different things depending on the app. For example, if an audio streaming app is "backgrounded", but the audio is still playing, probably its developers would want the same "foreground-behavior" of OTel to be running. So, in general, it's best not to depend on "app states" to define different behaviors, because we cannot guarantee that those would mean the same for all apps. So regarding this particular feature, it seems like it's better if we just define one timeout that's always present, regardless of the app state.

Please let me know if I missed something, @breedx-splk @bidetofevil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants