[chore] [exporter/elasticsearch] refactor bulkindexer to prepare for batch sender #34127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for having two parallel implementations for bulk indexing: the current buffering/async one, and a new synchronous one that would work with the exporterhelper batch sender.
Unnecessary indirection.
This is in preparation for introducing a new synchronous bulk indexer that will integrate with the exporterhelper batch sender: in that setup, the batch sender will batch before getting to the exporter, and make concurrent requests to the exporter's Consume* methods. The new "session" abstraction is intended to enable memory pooling and to efficiently and incrementally add a batch of documents before synchronously flushing.
carsonip
approved these changes
Jul 17, 2024
mwear
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor the Elasticsearch bulk indexer code to create an abstraction around the existing buffering, asynchronous bulk indexer.
This is preparation for supporting two implementations of bulk indexing: the existing asynchronous one, and a new synchronous one that works well with exporterhelper's batch sender -- see #32632.
Link to tracking Issue:
#32377
Testing:
N/A, this is a non-functional change.
Documentation:
N/A, pure refactoring.