Fix pprofile DurationNano to be a TypeUint64 #14188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianl
requested review from
a team,
bogdandrutu,
dmathieu,
dmitryax and
mx-psi
as code owners
pcommon.Timestamp better represents a point in time rather than a duration. So keeping the proto field type for DurationNano is a better fit. Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
profile-duration
branch
from
80184d1 to
7178c06
Compare
Member
|
Could you also open the -contrib PR that fixes the tests there? |
dmathieu
reviewed
Nov 19, 2025
florianl
added a commit
to florianl/opentelemetry-collector-contrib
that referenced
this pull request
Nov 19, 2025
Complementary change to open-telemetry/opentelemetry-collector#14188. Signed-off-by: Florian Lehner <[email protected]>
Contributor
Author
|
Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
dmathieu
reviewed
Nov 19, 2025
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking |
Member
There was a problem hiding this comment.
This is not a breaking change anymore. There should be 2 changelog entries.
An enhancement for the new method, and a deprecation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pcommon.Timestamp better represents a point in time rather than a duration. So keeping the proto field type for DurationNano is a better fit.
Corresponding Collector-contrib change: open-telemetry/opentelemetry-collector-contrib#44397
ping @open-telemetry/profiling-approvers
Link to tracking issue
Fixes #
Testing
Documentation