Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] create service/hostcapabilities package #12375

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jackgopack4
Copy link
Contributor

@jackgopack4 jackgopack4 commented Feb 12, 2025

Description

create service/hostcapabilities package to expose GetModuleInfos() from service/host. Also moves getExporters interface for GetExporters() to this package.

Link to tracking issue

Addresses planned work from #12296

Testing

none, creates interface for existing function

Documentation

changelog yaml

@jackgopack4 jackgopack4 marked this pull request as ready for review February 12, 2025 19:27
@jackgopack4 jackgopack4 requested a review from a team as a code owner February 12, 2025 19:27
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (f024b0d) to head (497be57).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12375   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         466      466           
  Lines       25325    25325           
=======================================
  Hits        23348    23348           
  Misses       1577     1577           
  Partials      400      400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackgopack4 Can you fix the merge conflicts?

@jackgopack4 jackgopack4 force-pushed the expose-getmoduleinfos-component-host branch from 1a83c3b to 5e6ee04 Compare February 14, 2025 18:50
@jackgopack4 jackgopack4 marked this pull request as draft February 14, 2025 19:24
@jackgopack4 jackgopack4 marked this pull request as ready for review February 14, 2025 19:55
@jackgopack4 jackgopack4 force-pushed the expose-getmoduleinfos-component-host branch from 0e5c388 to a7a6445 Compare February 18, 2025 16:47
@jackgopack4
Copy link
Contributor Author

jackgopack4 commented Feb 18, 2025

@jackgopack4 Can you fix the merge conflicts?

rebased on v0.120.0 release

@mrsillydog
Copy link

mrsillydog commented Feb 19, 2025

The work in open-telemetry/opentelemetry-collector-contrib#37249 is dependent on these changes since the removal of ModuleInfo from extension.Settings, so it would be valuable if we could get these changes included in the next release of the collector.

@mx-psi
Copy link
Member

mx-psi commented Feb 20, 2025

The work in open-telemetry/opentelemetry-collector-contrib#37249 is dependent on these changes since the removal of ModuleInfo from extension.Settings, so it would be valuable if we could get these changes included in the next release of the collector.

@mrsillydog This is a nice-to-have but you don't need to have this package to be able to use the functionality, you can just define the interface yourself and do a type assertion

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

@jackgopack4 jackgopack4 force-pushed the expose-getmoduleinfos-component-host branch from 2098be4 to 8e9bf7a Compare February 20, 2025 14:40
@jackgopack4 jackgopack4 requested a review from mx-psi February 20, 2025 14:58
@mx-psi
Copy link
Member

mx-psi commented Feb 20, 2025

@bogdandrutu will merge this on Monday unless you comment before then!

@jackgopack4 jackgopack4 force-pushed the expose-getmoduleinfos-component-host branch from 8e9bf7a to 812dd47 Compare February 20, 2025 18:13
@jackgopack4
Copy link
Contributor Author

rebased on main to remove merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants