-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service] create service/hostcapabilities package #12375
base: main
Are you sure you want to change the base?
[service] create service/hostcapabilities package #12375
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12375 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 466 466
Lines 25325 25325
=======================================
Hits 23348 23348
Misses 1577 1577
Partials 400 400 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackgopack4 Can you fix the merge conflicts?
1a83c3b
to
5e6ee04
Compare
0e5c388
to
a7a6445
Compare
rebased on v0.120.0 release |
The work in open-telemetry/opentelemetry-collector-contrib#37249 is dependent on these changes since the removal of |
@mrsillydog This is a nice-to-have but you don't need to have this package to be able to use the functionality, you can just define the interface yourself and do a type assertion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
2098be4
to
8e9bf7a
Compare
@bogdandrutu will merge this on Monday unless you comment before then! |
8e9bf7a
to
812dd47
Compare
rebased on main to remove merge conflict |
Description
create
service/hostcapabilities
package to exposeGetModuleInfos()
from service/host. Also moves getExporters interface forGetExporters()
to this package.Link to tracking issue
Addresses planned work from #12296
Testing
none, creates interface for existing function
Documentation
changelog yaml