Skip to content

[chore] use the same modernize as golanglint #14175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+41 −44
Open

[chore] use the same modernize as golanglint #14175

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d65388
[chore] use the same modernize as golanglint
paulojmdias Nov 17, 2025
f6b2a33
fix: revert -fix
paulojmdias Nov 17, 2025
ea96fd6
fix: fix -slicessort
paulojmdias Nov 17, 2025
8d64e8e
Merge branch 'main' into chore/use_golanglint_analyzer
paulojmdias Nov 17, 2025
732b1f3
feat: move modernize to internal/tools
paulojmdias Nov 18, 2025
9a7a782
Merge branch 'chore/use_golanglint_analyzer' of github.com:paulojmdia…
paulojmdias Nov 18, 2025
4f76246
chore: update golanglint
paulojmdias Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Makefile.Common
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,10 @@ fmt: common/gofmt common/goimports common/gofumpt
.PHONY: modernize
modernize:
$(GOCMD) run \
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest \
-fix -test -v ./...
golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest \
Copy link
Member

@dmathieu dmathieu Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using go run here, how about we add the package as a tools dependency and use it like the several other tools we already use?
That would allow us to lock into a specific version rather than using latest.

Copy link
Member Author

@paulojmdias paulojmdias Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads-up @dmathieu 🙏

Makes total sense, done in 732b1f3

-fix -test -v -any -bloop -fmtappendf -forvar -mapsloop -minmax -newexpr -omitzero -plusbuild \
-rangeint -reflecttypefor -slicescontains -slicessort -stditerators -stringscut \
-stringscutprefix -stringsseq -stringsbuilder -testingcontext -waitgroup ./...

.PHONY: tidy
tidy:
Expand Down
Loading