[chore] use the same modernize as golanglint #14175
Open
+41
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
github-actions
bot
added
the
release:risky-change
Signed-off-by: Paulo Dias <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14175 +/- ##
==========================================
- Coverage 92.25% 92.23% -0.03%
==========================================
Files 658 658
Lines 41186 41186
==========================================
- Hits 37998 37986 -12
- Misses 2182 2190 +8
- Partials 1006 1010 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmathieu
reviewed
Nov 18, 2025
Makefile.Common
Outdated
| $(GOCMD) run \ | ||
| golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest \ | ||
| -fix -test -v ./... | ||
| golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest \ |
Member
There was a problem hiding this comment.
Rather than using go run here, how about we add the package as a tools dependency and use it like the several other tools we already use?
That would allow us to lock into a specific version rather than using latest.
Member
Author
Signed-off-by: Paulo Dias <[email protected]>
…s/opentelemetry-collector into chore/use_golanglint_analyzer Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures we use the same modernize package as golanglint