Skip to content

Upgrade OTLP proto to v1.7. Add event_name to LogRecord API/SDK/PROTO #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DylanRussell
Copy link
Contributor

@DylanRussell DylanRussell commented Jun 18, 2025

Description

Upgrade to proto 1.7. The file diffs make it very hard to tell what has actually changed. Wish there were a better way to see actual diffs.

From reading through https://github.com/open-telemetry/opentelemetry-proto/releases -- most of the changes are to profiling which we don't support AFAICT, so I don't think we have to worry about that at all.

The only other notable change is that the EventName field was added to the LogRecord proto... I opened up #4644 for that.

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • [x ] No.

Checklist:

  • [ x] Followed the style guidelines of this project
  • [ x] Changelogs have been updated
  • [ x] Unit tests have been added
  • [x ] Documentation has been updated

@DylanRussell DylanRussell requested a review from a team as a code owner June 18, 2025 20:42
@DylanRussell DylanRussell changed the title Upgrade to otel proto v1.7 Upgrade OTLP proto to v1.7. Add event_name to LogRecord API/SDK/PROTO Jun 20, 2025
@emdneto emdneto added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jun 20, 2025
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we handle #4644 first then? Like in two separate PRs or the proto bump depends on all the changes to be done together?

@DylanRussell
Copy link
Contributor Author

Hmm we could do it separately.. Proto change doesn't require it. I'm heading out for weekend but can break it out on Monday if you think that's cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants