fix: Move the logs-sdk and metrics-sdk requires #1956
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianHawley
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
BrianHawley
changed the title
This makes it so the logs and metrics will work when you require like ```ruby require 'opentelemetry/sdk/logs' require 'opentelemetry/sdk/metrics' ``` Without getting 'opentelemetry-logs-api' or 'opentelemetry-logs-metrics' earlier. The opentelemetry-exporter-otlp-logs gem works around this, but I'm leaving that workaround there for now, so it will work with old versions of the opentelemetry-logs-sdk gem that are still locked. [Fixes open-telemetry#1955]
BrianHawley
force-pushed
the
fixes_1955
branch
from
f3f72ba to
489ffc6
Compare
Contributor
Author
|
Looks like truffleruby is failing for unrelated reasons. I may look into that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so the logs and metrics will work when you require like
Without requiring 'opentelemetry-logs-api' or 'opentelemetry-logs-metrics' earlier.
The opentelemetry-exporter-otlp-logs gem works around this, but I'm leaving that workaround there for now, so it will work with old versions of the opentelemetry-logs-sdk gem that are still locked.
[Fixes #1955]