-
Notifications
You must be signed in to change notification settings - Fork 300
Update GenAI conventions based on system-specific naming guidance #2046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f761b7 to
e365808
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
ecaa58d to
4d99508
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request implements system‐specific naming guidance for GenAI semantic conventions. It renames the attribute "gen_ai.system" to "gen_ai.provider.name", removes the "gen_ai" prefix from all "gen_ai.openai." attributes, and updates system names for Azure AI from "az.ai." to "azure.ai.*".
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| templates/registry/markdown/weaver.yaml | Added "OpenAI" to the acronyms list. |
| schema-next.yaml | Updated YAML schema with the new attribute mappings. |
| model/openai/registry.yaml | Introduced OpenAI attribute changes. |
| model/gen-ai/spans.yaml | Updated span definitions to use "gen_ai.provider.name" (with one instance using "gen_ai.provide.name"). |
| model/gen-ai/registry.yaml | Changed attribute IDs and documentation to reflect the new names. |
| model/gen-ai/metrics.yaml | Adjusted attribute references for openai metrics. |
| model/gen-ai/events.yaml | Updated event attribute references. |
| model/gen-ai/deprecated/registry-deprecated.yaml | Updated deprecated attributes. |
| docs/registry/attributes/*.md | Updated documentation references across several attribute pages. |
| docs/gen-ai/*.md | Updated spans, metrics, and events documentation to replace any "gen_ai.system" mentions with "gen_ai.provider.name" and "az.ai" with "azure.ai". |
| .github/ISSUE_TEMPLATE/*.yaml | Added the "openai" area to issue templates. |
| .chloggen/gen-ai-system-naming.yaml | Documented the breaking change in system naming. |
Comments suppressed due to low confidence (2)
model/gen-ai/spans.yaml:171
- It appears there is a typographical error in the attribute name 'gen_ai.provide.name'. To be consistent with the naming convention, it should be 'gen_ai.provider.name'.
`gen_ai.provide.name` MUST be set to `"azure.ai.inference"` and SHOULD be provided **at span creation time**.
docs/gen-ai/azure-ai-inference.md:58
- The attribute 'gen_ai.provide.name' contains a typo; it should be corrected to 'gen_ai.provider.name' for consistency with the overall change in naming conventions.
`gen_ai.provide.name` MUST be set to `"azure.ai.inference"` and SHOULD be provided **at span creation time**.
034fd5b to
2337a38
Compare
Implements #1708 for GenAI conventions
gen_ai.systemtogen_ai.provider.namegen_aiprefix fromgen_ai.openai.*attributes.az.ai.*system names toazure.ai.*.Related: #608