-
Notifications
You must be signed in to change notification settings - Fork 463
[api] Fix usage of scmsync projects via project links #18522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] Fix usage of scmsync projects via project links #18522
Conversation
6f433d6 to
7bf232c
Compare
It is not enough to check only the project itself for scmsync issue#18205
7bf232c to
9c0a9c0
Compare
|
@adrianschroeter This had to be reverted because nothing in the UI/API is prepared for @Package being nil in this situation. |
|
hi @hennevogel @eduardoj could you kindly extend this PR so that is properly managed by UI/API? |
|
No, it does not fix that the wrong package/project object is used for verification and the operation is run against a different project. |
Okay, that's true, it only fixes part of the use cases, not all of them. |
|
@danidoni but you aware that this is currently a new regression, blocking people? Shall I resubmit this? (Btw, it is wrong that nothing is prepared that @Package can be nil as this is the current design of the api. You have the very same thing also with packages from remote projects where you also need to be able to operate on the binaries.) |
Sure |
It is not enough to check only the project itself for scmsync
Fixes: #18205