Skip to content

Conversation

@adrianschroeter
Copy link
Member

@adrianschroeter adrianschroeter commented Sep 16, 2025

It is not enough to check only the project itself for scmsync

Fixes: #18205

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Sep 16, 2025
@adrianschroeter adrianschroeter force-pushed the fix_scmsync_via_project_link branch from 6f433d6 to 7bf232c Compare September 17, 2025 09:03
It is not enough to check only the project itself for scmsync

issue#18205
@hennevogel hennevogel force-pushed the fix_scmsync_via_project_link branch from 7bf232c to 9c0a9c0 Compare September 18, 2025 12:36
@hennevogel hennevogel merged commit 3e44f47 into openSUSE:master Sep 18, 2025
24 checks passed
@smithfarm
Copy link
Member

@adrianschroeter This had to be reverted because nothing in the UI/API is prepared for @Package being nil in this situation.

@fwag
Copy link

fwag commented Sep 19, 2025

hi @hennevogel @eduardoj could you kindly extend this PR so that is properly managed by UI/API?

@fwag
Copy link

fwag commented Sep 19, 2025

Discussed with @danidoni, this pull request #18372 from @hellcp fixes this issue

@adrianschroeter
Copy link
Member Author

No, it does not fix that the wrong package/project object is used for verification and the operation is run against a different project.

@danidoni
Copy link
Contributor

No, it does not fix that the wrong package/project object is used for verification and the operation is run against a different project.

Okay, that's true, it only fixes part of the use cases, not all of them.

@adrianschroeter
Copy link
Member Author

@danidoni but you aware that this is currently a new regression, blocking people?

Shall I resubmit this?

(Btw, it is wrong that nothing is prepared that @Package can be nil as this is the current design of the api. You have the very same thing also with packages from remote projects where you also need to be able to operate on the binaries.)

@danidoni
Copy link
Contributor

Shall I resubmit this?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Things related to the OBS RoR app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404: build/devel:RISCV:SLFO:Main/standard/riscv64/aaa_base

5 participants