This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Add null check for service map, fix percentile filter #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuali925
added a commit
that referenced
this pull request
Apr 22, 2021
* Add null check for service map query * Loop through filters when switching percentile filters * Add check before changing percentile filter
This was referenced Apr 22, 2021
joshuali925
added a commit
that referenced
this pull request
Apr 23, 2021
* Revert "Add null check for service map, fix percentile filter (#35)" This reverts commit 126c3db. * Revert "Merge pull request #34 from wrijeff/main" This reverts commit 66a9dcc, reversing changes made to 1cfd7b0. * Revert "Merge pull request #33 from wrijeff/main" This reverts commit 1cfd7b0, reversing changes made to e914162. * pick: Merge pull request #34 from wrijeff/main Fixed getTracesQuery, was returning 0 unexpectedly. * Add null check for service map, fix percentile filter (#35) * Add null check for service map query * Loop through filters when switching percentile filters * Add check before changing percentile filter * Change to traceGroup Co-authored-by: Jeff Wright <[email protected]>
joshuali925
added a commit
that referenced
this pull request
Apr 23, 2021
* Revert "Add null check for service map, fix percentile filter (#35)" This reverts commit 126c3db. * Revert "Merge pull request #34 from wrijeff/main" This reverts commit 66a9dcc, reversing changes made to 1cfd7b0. * Revert "Merge pull request #33 from wrijeff/main" This reverts commit 1cfd7b0, reversing changes made to e914162. * pick: Merge pull request #34 from wrijeff/main Fixed getTracesQuery, was returning 0 unexpectedly. * Add null check for service map, fix percentile filter (#35) * Add null check for service map query * Loop through filters when switching percentile filters * Add check before changing percentile filter * Change to traceGroup Co-authored-by: Jeff Wright <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
traceGroupFields.durationInNanosrather thandurationInNanosBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.