-
Notifications
You must be signed in to change notification settings - Fork 177
feat: replace StudioFooter with StudioFooterSlot #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace StudioFooter with StudioFooterSlot #1729
Conversation
|
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
asadali145
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Will approve after the final updates.
|
|
||
| const config = { | ||
| pluginSlots: { | ||
| footer_slot: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| footer_slot: { | |
| studio_footer_slot: { |
| @@ -0,0 +1,50 @@ | |||
| # Footer Slot | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Footer Slot | |
| # Studio Footer Slot |
4df84a7 to
f43ab9c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1729 +/- ##
==========================================
+ Coverage 93.46% 93.53% +0.07%
==========================================
Files 1124 1132 +8
Lines 22746 23043 +297
Branches 4823 4978 +155
==========================================
+ Hits 21259 21553 +294
+ Misses 1419 1414 -5
- Partials 68 76 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@brian-smith-tcril could you please review this PR? |
dd4361a to
4fd0101
Compare
|
Hi @brian-smith-tcril, I wanted to check in on this PR as we’re hoping to get it merged soon. Would you be able to take a look when possible? Happy to address any concerns. |
| "@dnd-kit/utilities": "^3.2.2", | ||
| "@edx/brand": "npm:@openedx/brand-openedx@^1.2.3", | ||
| "@edx/browserslist-config": "1.2.0", | ||
| "@edx/frontend-component-footer": "^14.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep this dependency in here. frontend-slot-footer has an unversioned peer dependency on frontend-component-footer, so keeping a versioned dependency in here is helpful.
Description
This PR replaces
StudioFooterwithStudioFooterSlot, allowing the customization of footer in the authoring MFE. StudioFooterSlot is added to frontend-slot-footer in this PR: openedx-unsupported/frontend-slot-footer#60Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Slack Thread: https://openedx.slack.com/archives/C04BM6YC7A6/p1741354164744729?thread_ts=1741187643.034179&cid=C04BM6YC7A6
Issue: https://github.com/mitodl/hq/issues/5689
Testing instructions
npm ci.env.config.jsxfile and add the following:Open the MFE in your browser and verify that the studio footer is replaced with 🦶 on all pages where it is present.
Other information
Include anything else that will help reviewers and consumers understand the change.
This PR depends on feat: add studio footer slot openedx-unsupported/frontend-slot-footer#60. First feat: add studio footer slot openedx-unsupported/frontend-slot-footer#60 needs to be merged and released and then this PR should be updated to the new version of
@openedx/frontend-slot-footerbefore merge.