[WIP] Handle heterogenous periods, dispatch and divide in SimulationBuilder #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Breaking changes
set_input
directly.Migration guide
set_input
directly AND relying on dispatch or divide behaviour, alter your code to obtain the subperiods of periods larger than the definition period of the variable being set. Alternately, you can construct your simulation data with SimulationBuilder.Fixes #564
This currently breaks the optimization from #827 because dispatch/divide can happen at the individual level and not just array-wise - @fpagnoux I'm not sure the best way to get that back, I'm thinking of performing checks on array equality at finalize time. WDYT ?