-
-
Notifications
You must be signed in to change notification settings - Fork 465
taxonomy: Move vitamins out of ingredients.txt #11807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
952254f
to
b4c174b
Compare
ca5b866
to
3a7d91c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11807 +/- ##
==========================================
- Coverage 49.88% 45.60% -4.29%
==========================================
Files 83 83
Lines 22984 23036 +52
Branches 5508 5519 +11
==========================================
- Hits 11466 10506 -960
- Misses 10121 11233 +1112
+ Partials 1397 1297 -100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3a7d91c
to
dc6c112
Compare
dc6c112
to
be7dd19
Compare
Vitamins being in food/ingredients.txt is causing some issues with parsing and translations and splitting translation/synonym lists. This moves all the specific vitamins out of the `food/ingredients.txt` file and into the `vitamins.txt` file, attempting to consolidate/merge the differences. See also Slack discussion: https://openfoodfacts.slack.com/archives/C02VDSWHT/p1743770992700109 B₆ vitamins have also been split up into individual chemical compounds. Previously, some vitamin B₆ synonyms would be compound names, and some compounds might even have other, different compounds associated with them. Other small things: - some normalisation of casing - some xx entries added - some wikidata entries added
be7dd19
to
a7fb8b9
Compare
|
Looks like the only tests that are still failing are ones related to I did copy the Is there some way somewhere to apply properties to all vitamins at once like the normal inheritance? (Other than adding a |
All vitamins are not vegetarian/vegan. See for example: https://en.wikipedia.org/wiki/Vitamin_B12 I would suggest to
from vitamins in ingredients.txt 2-update the expected test result (optional, if you want to go further) |
Yep, but that’s part of what will be addressed with #11669 and is out of scope for what this PR aims to do, unless we decide to just remove the
Some individual vitamins already have their own
I’m… not sure how that shows that B₁₂ is not vegan? The page says the compound is synthesised via a variety of bacteria cultures, not via any exploitation of other conscious, sentient, feeling beings. |
Continuation of #11807 by @Freso --------- Co-authored-by: Frederik “Freso” S. Olesen <[email protected]> Co-authored-by: Open Food Facts Bot <[email protected]> Co-authored-by: benbenben2 <[email protected]>
That one included the commit from here, right? |
Vitamins being in food/ingredients.txt is causing some issues with parsing and translations and splitting translation/synonym lists.
This moves all the specific vitamins out of the
food/ingredients.txt
file and into thevitamins.txt
file, attempting to consolidate/merge the differences.See also Slack discussion:
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1743770992700109
B₆ vitamins have also been split up into individual chemical compounds. Previously, some vitamin B₆ synonyms would be compound names, and some compounds might even have other, different compounds associated with them.
Other small things: