-
-
Notifications
You must be signed in to change notification settings - Fork 465
taxonomy: move all vitamins under en:vitamins #11816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vitamins being in food/ingredients.txt is causing some issues with parsing and translations and splitting translation/synonym lists. This moves all the specific vitamins out of the `food/ingredients.txt` file and into the `vitamins.txt` file, attempting to consolidate/merge the differences. See also Slack discussion: https://openfoodfacts.slack.com/archives/C02VDSWHT/p1743770992700109 B₆ vitamins have also been split up into individual chemical compounds. Previously, some vitamin B₆ synonyms would be compound names, and some compounds might even have other, different compounds associated with them. Other small things: - some normalisation of casing - some xx entries added - some wikidata entries added
/update_tests_results |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11816 +/- ##
==========================================
+ Coverage 49.88% 50.33% +0.45%
==========================================
Files 83 84 +1
Lines 22984 23001 +17
Branches 5508 5520 +12
==========================================
+ Hits 11466 11578 +112
+ Misses 10121 10003 -118
- Partials 1397 1420 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/update_tests_results |
1 similar comment
/update_tests_results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/update_tests_results |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Continuation of #11807 by @Freso