Skip to content

taxonomy: move all vitamins under en:vitamins #11816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 12, 2025
Merged

taxonomy: move all vitamins under en:vitamins #11816

merged 10 commits into from
May 12, 2025

Conversation

stephanegigandet
Copy link
Contributor

Continuation of #11807 by @Freso

Freso and others added 2 commits April 20, 2025 14:39
Vitamins being in food/ingredients.txt is causing some issues with
parsing and translations and splitting translation/synonym lists.

This moves all the specific vitamins out of the
`food/ingredients.txt` file and into the `vitamins.txt` file,
attempting to consolidate/merge the differences.

See also Slack discussion:
https://openfoodfacts.slack.com/archives/C02VDSWHT/p1743770992700109

B₆ vitamins have also been split up into individual chemical compounds.
Previously, some vitamin B₆ synonyms would be compound names, and
some compounds might even have other, different compounds associated
with them.

Other small things:
- some normalisation of casing
- some xx entries added
- some wikidata entries added
@stephanegigandet stephanegigandet requested a review from a team as a code owner April 23, 2025 09:30
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 additives 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Apr 23, 2025
@github-project-automation github-project-automation bot moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2025
@stephanegigandet
Copy link
Contributor Author

/update_tests_results

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 50.33%. Comparing base (e8deee5) to head (2032c8d).
Report is 145 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/ProductOpener/Ingredients.pm 92.85% 0 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11816      +/-   ##
==========================================
+ Coverage   49.88%   50.33%   +0.45%     
==========================================
  Files          83       84       +1     
  Lines       22984    23001      +17     
  Branches     5508     5520      +12     
==========================================
+ Hits        11466    11578     +112     
+ Misses      10121    10003     -118     
- Partials     1397     1420      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stephanegigandet
Copy link
Contributor Author

/update_tests_results

1 similar comment
@stephanegigandet
Copy link
Contributor Author

/update_tests_results

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in Ingredient analysis May 3, 2025
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues May 3, 2025
@github-actions github-actions bot added 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling Tags labels May 9, 2025
@stephanegigandet
Copy link
Contributor Author

/update_tests_results

Copy link

sonarqubecloud bot commented May 9, 2025

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Todo to In Progress in 📦 Packaging improvements May 10, 2025
@stephanegigandet stephanegigandet merged commit d05c225 into main May 12, 2025
14 checks passed
@stephanegigandet stephanegigandet deleted the vitamins branch May 12, 2025 11:52
@github-project-automation github-project-automation bot moved this from In Progress to Done in 📦 Packaging improvements May 12, 2025
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Ingredient analysis May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling ✔︎ Spellcheck Tags 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants