Skip to content

feat: adds folksonomy-editor to product page #12002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kirtanchandak
Copy link

@kirtanchandak kirtanchandak commented Jun 4, 2025

[% INCLUDE web/common/includes/off_webcomponents_configuration.tt.html language_code = lc country_code = cc robotoff_domain = robotoff_url images_domain = images_subdomain api_domain = formatted_subdomain %]
[% INCLUDE web/common/includes/off_webcomponents_configuration.tt.html language_code = lc country_code = cc
robotoff_domain = robotoff_url images_domain = images_subdomain api_domain = formatted_subdomain folksonomy_uri =
"https://api.folksonomy.openfoodfacts.org" %]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, it will have to come from configuration, so you have to pass the url in the context at the point in the code where this template is called.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.56%. Comparing base (e8deee5) to head (1a34376).
Report is 266 commits behind head on main.

Files with missing lines Patch % Lines
lib/ProductOpener/Display.pm 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12002      +/-   ##
==========================================
+ Coverage   49.88%   50.56%   +0.67%     
==========================================
  Files          83       84       +1     
  Lines       22984    22921      -63     
  Branches     5508     5509       +1     
==========================================
+ Hits        11466    11589     +123     
+ Misses      10121     9918     -203     
- Partials     1397     1414      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org Display config labels Jun 5, 2025
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 17, 2025
@@ -18,7 +18,11 @@
- EVENTS_USERNAME
- EVENTS_PASSWORD
- REDIS_URL
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have left merge conflict marks @kirtanchandak

# This service watch for new images to trigger ocr and robotoff processing
command:
["perl", "scripts/run_cloud_vision_ocr.pl", "/mnt/podata/new_images"]
=======
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@@ -64,7 +64,11 @@ BEGIN {
$rate_limiter_blocking_enabled
$facets_kp_url
$redis_url
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link

sonarqubecloud bot commented Jul 8, 2025

@alexgarel
Copy link
Member

closing in favour of #12136 (agreed with @kirtanchandak )

@alexgarel alexgarel closed this Jul 8, 2025
@github-project-automation github-project-automation bot moved this from To discuss and validate to Done in 🍊 Open Food Facts Server issues Jul 8, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in 🐾 Open Pet Food Facts Jul 8, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in 🧴 Open Beauty Facts Jul 8, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in 📸 Open Products Facts Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Display 💥 Merge Conflicts 💥 Merge Conflicts 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org Product Page 🤖 Robotoff Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests Web components
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Replace the Folksonomy Engine in the Product Page by the Webcomponent
4 participants