-
-
Notifications
You must be signed in to change notification settings - Fork 476
feat: adds folksonomy-editor to product page #12002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds folksonomy-editor to product page #12002
Conversation
[% INCLUDE web/common/includes/off_webcomponents_configuration.tt.html language_code = lc country_code = cc robotoff_domain = robotoff_url images_domain = images_subdomain api_domain = formatted_subdomain %] | ||
[% INCLUDE web/common/includes/off_webcomponents_configuration.tt.html language_code = lc country_code = cc | ||
robotoff_domain = robotoff_url images_domain = images_subdomain api_domain = formatted_subdomain folksonomy_uri = | ||
"https://api.folksonomy.openfoodfacts.org" %] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, it will have to come from configuration, so you have to pass the url in the context at the point in the code where this template is called.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12002 +/- ##
==========================================
+ Coverage 49.88% 50.56% +0.67%
==========================================
Files 83 84 +1
Lines 22984 22921 -63
Branches 5508 5509 +1
==========================================
+ Hits 11466 11589 +123
+ Misses 10121 9918 -203
- Partials 1397 1414 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -18,7 +18,11 @@ | |||
- EVENTS_USERNAME | |||
- EVENTS_PASSWORD | |||
- REDIS_URL | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have left merge conflict marks @kirtanchandak
# This service watch for new images to trigger ocr and robotoff processing | ||
command: | ||
["perl", "scripts/run_cloud_vision_ocr.pl", "/mnt/podata/new_images"] | ||
======= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -64,7 +64,11 @@ BEGIN { | |||
$rate_limiter_blocking_enabled | |||
$facets_kp_url | |||
$redis_url | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
|
closing in favour of #12136 (agreed with @kirtanchandak ) |
What
Adds
folksonomy-editor
to product pagefixes: Replace the Folksonomy Engine in the Product Page by the Webcomponent #12016
Screenshot
Related issue(s) and discussion
https://openfoodfacts.slack.com/archives/C01M1T2E8L8/p1748869435864089