Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347491: Add detail error messages when ThreadPoolExecutor's parameter is illegal #23050

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

He-Pin
Copy link

@He-Pin He-Pin commented Jan 11, 2025

Motivation:
When a user passes a wrong parameter, the current implementation throws an IllegalArgumentException with an error message null, which is not helpful.

Modification:
Add detail error messages.

Result:
Helpful messages.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8347491

Issue

  • JDK-8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message (Bug - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23050/head:pull/23050
$ git checkout pull/23050

Update a local copy of the PR:
$ git checkout pull/23050
$ git pull https://git.openjdk.org/jdk.git pull/23050/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23050

View PR using the GUI difftool:
$ git pr show -t 23050

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23050.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jan 11, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2025

Hi @He-Pin, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user He-Pin" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jan 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 11, 2025

@He-Pin The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link

openjdk bot commented Jan 11, 2025

@He-Pin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@He-Pin He-Pin changed the title chore: Add detail error messages when ThreadPoolExecutor's parameter is illegal 9077998: Add detail error messages when ThreadPoolExecutor's parameter is illegal Jan 11, 2025
@openjdk
Copy link

openjdk bot commented Jan 12, 2025

@He-Pin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@He-Pin He-Pin changed the title 9077998: Add detail error messages when ThreadPoolExecutor's parameter is illegal 8347491: Add detail error messages when ThreadPoolExecutor's parameter is illegal Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant