-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347491: Add detail error messages when ThreadPoolExecutor's parameter is illegal #23050
base: master
Are you sure you want to change the base?
Conversation
Hi @He-Pin, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user He-Pin" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
❗ This change is not yet ready to be integrated. |
@He-Pin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@He-Pin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Motivation:
When a user passes a wrong parameter, the current implementation throws an IllegalArgumentException with an error message
null
, which is not helpful.Modification:
Add detail error messages.
Result:
Helpful messages.
Progress
Error
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23050/head:pull/23050
$ git checkout pull/23050
Update a local copy of the PR:
$ git checkout pull/23050
$ git pull https://git.openjdk.org/jdk.git pull/23050/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23050
View PR using the GUI difftool:
$ git pr show -t 23050
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23050.diff