[KNI] go.mod: revert version to 1.21 #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ffromani
force-pushed
the
revert-go-version-4.16
branch
from
00bb65f to
8621d41
Compare
ffromani
changed the title
ffromani
force-pushed
the
revert-go-version-4.16
branch
4 times, most recently
from
9752622 to
decb7a5
Compare
ffromani
changed the title
we should be buildable with golang 1.21, and we don't use 1.22 features directly nor in deps, so let's revert to 1.21. This includes both revert to builder images and go.mod. It seems we can't really split the two like originally planned. Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
revert-go-version-4.16
branch
from
decb7a5 to
2a6e194
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should be buildable with golang 1.21, and
we don't use 1.22 features directly nor in deps, so let's revert to 1.21.