Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TELCODOCS#2040: Multi-network policy support for bond CNI and IPVLAN #84671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Nov 8, 2024

Version(s):
4.18

Issues:

Link to docs preview:

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 8, 2024
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented Nov 8, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented Nov 8, 2024

Hi @zeeke
Could you please review this PR?
Thanks!

* Bond Container Network Interface (CNI) over SR-IOV
* OVN-Kubernetes additional networks
MacVLAN additional networks are fully supported.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what this statement exactly means? It should be the same as MAC Virtual Local Area Network (MacVLAN).

Copy link
Contributor Author

@sr1kar99 sr1kar99 Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why we had a separate line for this network type.
It does seem like fluff.
WDYT of getting rid of this line? @zeeke

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not defend a position if a user claims an explanation, so it's okay to remove it from my side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a concept of partial support and full support for the other network types?
It is only in this case I think this statement makes sense.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one note about the SR-IOV networks, that is stated right after this paragraph:
https://github.com/openshift/openshift-docs/pull/84671/files#diff-39bf1f67d4adfc408401fdf1ee603afb080600e2dfa028993efa249aad639d8fR21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants