-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TELCODOCS#2040: Multi-network policy support for bond CNI and IPVLAN #84671
base: main
Are you sure you want to change the base?
Conversation
🤖 Fri Nov 08 13:08:32 - Prow CI generated the docs preview: |
@sr1kar99: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hi @zeeke |
* Bond Container Network Interface (CNI) over SR-IOV | ||
* OVN-Kubernetes additional networks | ||
MacVLAN additional networks are fully supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know what this statement exactly means? It should be the same as MAC Virtual Local Area Network (MacVLAN)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea why we had a separate line for this network type.
It does seem like fluff.
WDYT of getting rid of this line? @zeeke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not defend a position if a user claims an explanation, so it's okay to remove it from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a concept of partial support and full support for the other network types?
It is only in this case I think this statement makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only one note about the SR-IOV networks, that is stated right after this paragraph:
https://github.com/openshift/openshift-docs/pull/84671/files#diff-39bf1f67d4adfc408401fdf1ee603afb080600e2dfa028993efa249aad639d8fR21
Version(s):
4.18
Issues:
Link to docs preview:
QE review: