Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TELCODOCS#2040: Multi-network policy support for bond CNI and IPVLAN #84671

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

TELCODOCS#2040: Multi-network policy support for bond CNI and IPVLAN #84671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion networking/multiple_networks/configuring-multi-network-policy.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,15 @@ include::_attributes/common-attributes.adoc[]

toc::[]

As a cluster administrator, you can configure a multi-network policy for a Single-Root I/O Virtualization (SR-IOV), MAC Virtual Local Area Network (MacVLAN), or OVN-Kubernetes additional networks. MacVLAN additional networks are fully supported. Other types of additional networks, such as IP Virtual Local Area Network (IPVLAN), are not supported.
As a cluster administrator, you can configure a multi-network policy for any of the following network types:

* Single-Root I/O Virtualization (SR-IOV)
* MAC Virtual Local Area Network (MacVLAN)
* IP Virtual Local Area Network (IPVLAN)
* Bond Container Network Interface (CNI) over SR-IOV
* OVN-Kubernetes additional networks
MacVLAN additional networks are fully supported.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what this statement exactly means? It should be the same as MAC Virtual Local Area Network (MacVLAN).

Copy link
Contributor Author

@sr1kar99 sr1kar99 Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why we had a separate line for this network type.
It does seem like fluff.
WDYT of getting rid of this line? @zeeke

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not defend a position if a user claims an explanation, so it's okay to remove it from my side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a concept of partial support and full support for the other network types?
It is only in this case I think this statement makes sense.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one note about the SR-IOV networks, that is stated right after this paragraph:
https://github.com/openshift/openshift-docs/pull/84671/files#diff-39bf1f67d4adfc408401fdf1ee603afb080600e2dfa028993efa249aad639d8fR21


[NOTE]
====
Expand Down