Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-controller: add HighAvailability repo #61519

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

fabbione
Copy link
Contributor

this will be required in the context of 2 Nodes OpenShift

See: https://issues.redhat.com/browse/OCPEDGE-1493

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 11, 2025
@fabbione
Copy link
Contributor Author

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

Hi @fabbione. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

this will be required in the context of 2 Nodes OpenShift
See: https://issues.redhat.com/browse/OCPEDGE-1493

Signed-off-by: Fabio M. Di Nitto <[email protected]>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@fabbione: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@fabbione fabbione requested a review from jlebon February 12, 2025 05:07
@jlebon
Copy link
Member

jlebon commented Feb 13, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@joepvd
Copy link
Contributor

joepvd commented Feb 18, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabbione, jlebon, joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit dcbfaa9 into openshift:master Feb 18, 2025
5 of 6 checks passed
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@fabbione: Updated the following 12 configmaps:

  • base-repos configmap in namespace ocp at cluster vsphere02 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build01 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build04 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build05 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build10 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build11 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build07 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster app.ci using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build02 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build09 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build03 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo
  • base-repos configmap in namespace ocp at cluster build06 using the following files:
    • key ocp-4.19-rhel96.repo using file core-services/release-controller/_repos/ocp-4.19-rhel96.repo

In response to this:

this will be required in the context of 2 Nodes OpenShift

See: https://issues.redhat.com/browse/OCPEDGE-1493

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vishnuchalla pushed a commit to vishnuchalla/release that referenced this pull request Feb 19, 2025
this will be required in the context of 2 Nodes OpenShift
See: https://issues.redhat.com/browse/OCPEDGE-1493

Signed-off-by: Fabio M. Di Nitto <[email protected]>
lihongyan1 pushed a commit to lihongyan1/release that referenced this pull request Feb 20, 2025
this will be required in the context of 2 Nodes OpenShift
See: https://issues.redhat.com/browse/OCPEDGE-1493

Signed-off-by: Fabio M. Di Nitto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants