Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPEDGE-1493: extensions: add 2no-ha required by Two Node OpenShift #1743

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

fabbione
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from jschintag and marmijo February 11, 2025 08:42
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 11, 2025
Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

Hi @fabbione. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabbione
Copy link
Contributor Author

fabbione commented Feb 11, 2025

Hey guys,

very first time contributing to RHCOS, I am sure I missed a few bits here and there, hopefully not too many :)

the name 2no-ha was explicity selected to avoid using HighAvailability as in the context of OpenShift could
be misleading. The RHEL HighAvailability channel provides the packages required for Two Nodes OpenShift
controller plane deployments.

See also:
https://gitlab.cee.redhat.com/coreos/redhat-coreos/-/merge_requests/1553
#1743
openshift/machine-config-operator#4843
openshift-eng/ocp-build-data#6091
openshift/release#61519

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but looks sane to me overall. We'll have to wait for the other two PRs to merge for CI to pass here.

extensions-ocp-rhel-9.6.yaml Outdated Show resolved Hide resolved
@jlebon
Copy link
Member

jlebon commented Feb 13, 2025

/approve

Let's wait for the repos to be plumbed through before triggering CI to not waste resources.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2025
@fabbione
Copy link
Contributor Author

@jlebon repos should be plumbed now.

@jlebon
Copy link
Member

jlebon commented Feb 18, 2025

/ok-to-test
/lgtm

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 18, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabbione, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member

jlebon commented Feb 18, 2025

/override ci/prow/e2e-aws
/override ci/prow/images
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 18, 2025
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/e2e-aws, ci/prow/images

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/images
/label acknowledge-critical-fixes-only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@fabbione: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlebon jlebon changed the title extensions: add 2no-ha required by Two Node OpenShift OCPEDGE-1493: extensions: add 2no-ha required by Two Node OpenShift Feb 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2025

@fabbione: This pull request references OCPEDGE-1493 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

See: https://issues.redhat.com/browse/OCPEDGE-1493

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 0a76960 into openshift:master Feb 18, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants