-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPEDGE-1493: extensions: add 2no-ha required by Two Node OpenShift #1743
Conversation
Hi @fabbione. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey guys, very first time contributing to RHCOS, I am sure I missed a few bits here and there, hopefully not too many :) the name 2no-ha was explicity selected to avoid using HighAvailability as in the context of OpenShift could See also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment but looks sane to me overall. We'll have to wait for the other two PRs to merge for CI to pass here.
See: https://issues.redhat.com/browse/OCPEDGE-1493 Signed-off-by: Fabio M. Di Nitto <[email protected]>
/approve Let's wait for the repos to be plumbed through before triggering CI to not waste resources. |
@jlebon repos should be plumbed now. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabbione, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-aws |
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/e2e-aws, ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@fabbione: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@fabbione: This pull request references OCPEDGE-1493 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
See: https://issues.redhat.com/browse/OCPEDGE-1493