Skip to content

[debug] [don't merge]: testing karpenter configuration #65787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Jun 6, 2025

/hold

This PR is a testing grounds for figuring out how to configure our kubernetes-sigs/karpenter fork to be able to run the upstream unit tests and other validation checks e.g. make unit and make verify.

do not merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2025
Copy link
Contributor

openshift-ci bot commented Jun 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2025
@openshift-ci openshift-ci bot requested review from bear-redhat and deepsm007 June 6, 2025 17:28
@maxcao13
Copy link
Member Author

maxcao13 commented Jun 6, 2025

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-unit

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the test-karpenter-core-config-dont-merge branch from 9fd6a9a to 83474d9 Compare June 6, 2025 17:54
@maxcao13
Copy link
Member Author

maxcao13 commented Jun 6, 2025

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-unit

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the test-karpenter-core-config-dont-merge branch from 83474d9 to 7e40a95 Compare June 6, 2025 18:55
@maxcao13
Copy link
Member Author

maxcao13 commented Jun 6, 2025

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-unit pull-ci-maxcao13-karpenter-openshift-main-verify

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the test-karpenter-core-config-dont-merge branch from 7e40a95 to b913ed2 Compare June 6, 2025 20:49
@maxcao13
Copy link
Member Author

maxcao13 commented Jun 6, 2025

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-verify

test passed :D

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13
Copy link
Member Author

maxcao13 commented Jun 6, 2025

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-unit pull-ci-maxcao13-karpenter-openshift-main-verify

🤞

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13
Copy link
Member Author

maxcao13 commented Jun 9, 2025

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-unit pull-ci-maxcao13-karpenter-openshift-main-verify pull-ci-maxcao13-karpenter-openshift-main-images pull-ci-maxcao13-karpenter-openshift-main-e2e-hypershift

Trying to see if e2e tests will work like how I've hacked it together...

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the test-karpenter-core-config-dont-merge branch from a2df609 to 22a6fc5 Compare June 9, 2025 21:04
@maxcao13
Copy link
Member Author

maxcao13 commented Jun 9, 2025

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-images pull-ci-maxcao13-karpenter-openshift-main-e2e-hypershift

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13
Copy link
Member Author

maxcao13 commented Jun 9, 2025

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-images pull-ci-maxcao13-karpenter-openshift-main-e2e-hypershift

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the test-karpenter-core-config-dont-merge branch from 22a6fc5 to a9c21a4 Compare June 9, 2025 22:07
@maxcao13
Copy link
Member Author

maxcao13 commented Jun 9, 2025

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-images

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13 maxcao13 force-pushed the test-karpenter-core-config-dont-merge branch from a9c21a4 to 2fcf0cb Compare June 10, 2025 00:10
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@maxcao13: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-maxcao13-karpenter-openshift-main-e2e-hypershift maxcao13/karpenter presubmit Presubmit changed
pull-ci-maxcao13-karpenter-openshift-main-images maxcao13/karpenter presubmit Presubmit changed
pull-ci-maxcao13-karpenter-openshift-main-unit maxcao13/karpenter presubmit Presubmit changed
pull-ci-maxcao13-karpenter-openshift-main-verify maxcao13/karpenter presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@maxcao13
Copy link
Member Author

/pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-images

@openshift-ci-robot
Copy link
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

@maxcao13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check-gh-automation-tide 9fd6a9a link true /test check-gh-automation-tide
ci/prow/check-gh-automation 2fcf0cb link true /test check-gh-automation
ci/prow/config 2fcf0cb link true /test config
ci/prow/owners 2fcf0cb link true /test owners
ci/rehearse/maxcao13/karpenter/openshift-main/e2e-hypershift 22a6fc5 link unknown /pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-e2e-hypershift
ci/rehearse/maxcao13/karpenter/openshift-main/images 2fcf0cb link unknown /pj-rehearse pull-ci-maxcao13-karpenter-openshift-main-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants