Model Triangle Inequality Fix #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbeattie42
force-pushed
the
model-triangle-inequality
branch
from
1025785 to
4e83ff5
Compare
alexbeattie42
force-pushed
the
model-triangle-inequality
branch
from
4e83ff5 to
c82ded4
Compare
|
Seems like a reasonable enough change that fixes some of the tests under debug conditions, nicely spotted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3941
Brief summary of changes
Resolves this issue
Related PR in model repository
I created this python script which identifies in a
.osimmodel which inertial constraints will fail the triangle inequality and calculates the minimum change in one element required to fix them.Testing I've completed
I have tested with the models before and after and in my testing the models do not work prior to the repair and do work after.
Looking for feedback on...
@aymanhab can you take a look at these?
CHANGELOG.md (choose one)
This change is