-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render the side
tag
#10303
base: develop
Are you sure you want to change the base?
render the side
tag
#10303
Conversation
); | ||
results.push({ | ||
type: isSide ? 'side' : 'direction', | ||
angle: (geoAngle(this, resolver.entity(nodeId), projection) * (180 / Math.PI)) + (isSide ? 0 : 90) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, though I wonder if reusing the “cone” would risk confusing some users. Some mappers are also using side=*
on traffic_signals=*
vertices. This change will cause these vertices’ cones to point away from the street, which would be inconsistent with the cones for standalone traffic_signals=*
nodes. Plus, it might be necessary to combine side=*
with direction=*
in some cases. In the screenshot above, this would imply four different “faces” rather than two. Maybe side=*
could act as more of a mask, chopping the directional cone in half?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering about how to visualize the side
as well.
The direction
is more of a "looking direction" or "affected area".
But the side
is more of "an anchor" or a "connection point" or a "this belongs to over there" indicator. However I don't see a way to visualize those well. Especially when the actual "anchor point" is unknown (we only now "it is to the right").
The other UI we use to show direction of elements is on barrier=retaining_wall
and such with the small arrows next to the line. Maybe this is something we can build upon for this UI? Like one of those arrows next to the node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, though I wonder if reusing the “cone” would risk confusing some users.
[...]
Maybeside=*
could act as more of a mask, chopping the directional cone in half?
That's a cool idea, although it might be confusing if side
+direction
renders differently to side
and direction
on their own? Here's what it could look like:
Like one of those arrows next to the node?
Something like this maybe?
Any other ideas would be greatly appreciated...
This PR renders the
side=*
tag, similar to howdirection=*
is rendered.side=*
is used withhighway=cyclist_waiting_aid
, but it is currently slow and tricky to use this tag. This PR aims to make it much more intuitive to map theside
. It can be tested from here.