OCPBUGS-17157: operators/v1alpha1: expose CSV copied logic #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
changed the title
38 tasks
perdasilva
reviewed
Aug 2, 2023
stevekuznetsov
force-pushed
the
skuznets/csv-copied
branch
from
04edc4f
to
7b4d617
Compare
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 41.94% 42.16% +0.22%
==========================================
Files 39 39
Lines 3488 3491 +3
==========================================
+ Hits 1463 1472 +9
+ Misses 1879 1873 -6
Partials 146 146
|
stevekuznetsov
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We want to use a partial object metadata query for CSVs to reduce resource utilization. We still want to ask questions about whether these CSVs are copied, so we need to refactor this method to take only object metadata. While it's not a perfect port of the previous logic, it defies explanation how an object would have all the other markings of being copied but the wrong status. Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/csv-copied
branch
from
7b4d617
to
0e9374d
Compare
|
New changes are detected. LGTM label has been removed. |
|
Going to self-tag since all I did was add a unit test to appease the coverage gods |
openshift-merge-robot
merged commit 409ec70
into
operator-framework:master
5 checks passed
|
I post-merge lgtm XD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use a partial object metadata query for CSVs to reduce resource utilization. We still want to ask questions about whether these CSVs are copied, so we need to refactor this method to take only object metadata. While it's not a perfect port of the previous logic, it defies explanation how an object would have all the other markings of being copied but the wrong status.