rds.py: Added RDMA restrack resource usage in rds.py script #176
Conversation
Enhance rds.py to report RDMA restrack resource usage (PD, CQ, QP, CM_ID, MR, CTX, SRQ) per RDS interface. This is based on the xa-for-each traversal of res[] arrays in struct ib_device. Useful for visibility into actual RDMA object usage and correlating with rdma resource show script Signed-off-by: Palak Tripathi <[email protected]>
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
OCA Required
anandakhoje
left a comment
anandakhoje
left a comment
There was a problem hiding this comment.
Overall, as "rdma res show" tracks all RDMA resources and not only of that being used by RDS devices, this should be more non-RDS specific. Provided comments inline.
…o have a track of all the devices
anandakhoje
left a comment
anandakhoje
left a comment
There was a problem hiding this comment.
Looks good to me.
Reviewed-by: Anand Khoje <anand.a.khoje.oracle.com>
brenns10
left a comment
brenns10
left a comment
There was a problem hiding this comment.
Just a few small changes requested, otherwise this looks quite good, thank you!
|
One last thing, check the pre-commit outputs here and ensure that the hooks pass. You can either apply the changes shown in the output, or you can setup |
|
Another thing - can you file a bug for these RDS improvements (targetting "next" -- this is also covered in the workflow doc). Then include the "Orabug: " statement in the commit messages? It can be the one Orabug for both this and #177. |
brenns10
left a comment
brenns10
left a comment
There was a problem hiding this comment.
So, pre-commit still reports formatting issues, but I'm willing to approve this PR and fix-up those myself.
3 participants
Enhance rds.py to report RDMA restrack resource usage (PD, CQ, QP, CM_ID, MR, CTX, SRQ) per RDS interface. This is based on the xa-for-each traversal of res[] arrays in struct ib_device. Useful for visibility into actual RDMA object usage and correlating with rdma resource show script