rds.py: Added RDS QP states diagnostics in rds helper #177
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
OCA Required
anandakhoje
left a comment
anandakhoje
left a comment
There was a problem hiding this comment.
EQ has to be added for RCQ as well.
anandakhoje
left a comment
anandakhoje
left a comment
There was a problem hiding this comment.
This looks good to me.
Reviewed-by: Anand Khoje [email protected]
brenns10
left a comment
brenns10
left a comment
There was a problem hiding this comment.
Just a couple small updates requested. Also please check the output of the pre-commit hooks here. You can either manually apply the changes shown there, or setup pre-commit (documented in the drgn-tools developer workflow) and use pre-commit run --all-files to automatically apply fixes.
|
Another thing - can you file a bug for these RDS improvements (targetting "next" -- this is also covered in the workflow doc). Then include the "Orabug: " statement in the commit messages? It can be the one Orabug for both this and #176. |
brenns10
left a comment
brenns10
left a comment
There was a problem hiding this comment.
Sorry, the changes here caused a new issue. Please setup & run pre-commit, as it is able to catch these, and automatically apply all the style changes it's complaining about.
Or check the CI run and apply the changes manually, if you don't want to use pre-commit.
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
OCA Required
Added a new helper to extract and display detailed RDS QP state, including source/destination IPs. This enhances visibility into per-connection RDMA hardware state via ib_connection traversal. Useful for debugging, states and RDMA mapping. Orabug: 38221449 Signed-off-by: Palak Tripathi <[email protected]> Reviewed-by: Anand Khoje <[email protected]> Reviewed-by: Stephen Brennan <[email protected]>
Fixes: 928e8ae ("rds.py: Added RDMA restrack resource usage in rds.py script") Signed-off-by: Stephen Brennan <[email protected]>
3 participants
Added a new helper to extract and display detailed RDS QP state, including source/destination IPs. This enhances visibility into per-connection RDMA QP state via ib_connection traversal.