Update README.maintainer.md for GAP updates
#1281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1281 +/- ##
=======================================
Coverage 76.55% 76.56%
=======================================
Files 61 61
Lines 4901 4902 +1
=======================================
+ Hits 3752 3753 +1
Misses 1149 1149 🚀 New features to boost your workflow:
|
fingolfin
reviewed
Oct 30, 2025
Comment on lines
110
to
122
| 7. In `GAP.jl`, create a PR with the following changes: | ||
| 1. In the `Project.toml` update the compat bounds as follows: | ||
| - `GAP_jll` to the `version` from step 1, with a `~` prefix. | ||
| - `GAP_lib_jll` to the `version` from step 3, with a `~` prefix. | ||
| - %TODO: `GAP_pkg_juliainterface` | ||
| - For each `GAP_pkg_*_jll` package that was updated in step 6, update to the new version | ||
| with a `~` prefix. You can find the new version numbers in the registry PRs from step 6. | ||
| 2. Run `etc/update_artifact.jl` with the new GAP version as argument to the `Artifacts.toml` file. | ||
| See the top of that script for instructions. | ||
| 3. If the GAP release is not ABI-compatible with the previous one, update the minor part of the version | ||
| of `GAP.jl` in its `Project.toml` | ||
| 4. If the GAP release was created from a new release branch (e.g. `stable-4.15` instead of `stable-4.14`), | ||
| then update occurrences in `.github/workflows/gap.yml` accordingly. |
Member
There was a problem hiding this comment.
Perhaps we can write a script to take care of most of this, given just the new GAP version? (Not for this PR! just thinking out loud)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1203 with the learnings that I made during the GAP 4.15.0 and 4.15.1 updates.
There are two places where I should add another sentence about how
juliainterfaceis special at that place. I'll do that before we merge this, but I wanted to already open this PR to get some feedback.