Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about bibtool version, minor fix in testsuite #4356

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

lkastner
Copy link
Member

@lkastner lkastner commented Nov 27, 2024

Running with different bibtool version may produce wrong results.
Fix remnants of #4348, ie fix #4355

cc @HereAround

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (43d0c68) to head (74edbf4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4356   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files         649      649           
  Lines       86430    86430           
=======================================
  Hits        72882    72882           
  Misses      13548    13548           

@lkastner lkastner requested a review from HereAround November 27, 2024 13:05
Copy link
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for working on this @lkastner !

@HereAround HereAround merged commit 5d4b919 into master Nov 27, 2024
30 of 31 checks passed
@HereAround HereAround deleted the lk/minor_fixes branch November 27, 2024 16:20
@lgoettgens lgoettgens mentioned this pull request Dec 12, 2024
benlorenz pushed a commit that referenced this pull request Dec 12, 2024
benlorenz pushed a commit that referenced this pull request Dec 12, 2024
benlorenz added a commit that referenced this pull request Dec 13, 2024
Backports for release 1.2.2:

fix galois_group problem. #4396
Fix zero-dimensional cone in cones in PolyhedralGeometry #4336
Fix up generic characteristic method for localized rings. #4346
test/PolyhedralGeometry: remove some prefer blocks #4351
Add comment about bibtool version, minor fix in testsuite #4356
Add hash method for RayVector #4354
Fix indent in AlgebraicCycles.md #4368
Fix toric typo #4367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparing ideal sheaves
3 participants