Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about bibtool version, minor fix in testsuite #4356

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Add comment about bibtool version, minor fix in testsuite #4356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f17cf3
DevDocs: Comment on bibtool version
lkastner Nov 27, 2024
74edbf4
ToricVarieties: Fix test that got confused and selected the wrong var…
lkastner Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/src/DeveloperDocumentation/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ changes in the bibliography. If so, this test fails and indicates that the
is not required that this test is passed. Still, please feel encouraged to fix
this failure by running `bibtool` locally as explained above.

!!! note "bibtool produces changes in unrelated parts of oscar_references.bib"
Sometimes `bibtool` will produce many changes when run locally. This can be
caused by a version difference. The version used in our github actions is
2.68. Check your version by running `bibtool -V`. When running this
command, please also pay attention whether any "Special configuration
options" are set.

Please follow the additional guidelines below, that are not checked by bibtool:

- Do not escape special characters like umlauts or accented characters. Instead, use the unicode character directly.
Expand Down
3 changes: 2 additions & 1 deletion test/AlgebraicGeometry/ToricVarieties/toric_blowups.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
@test !issubset(pbJ_str, ideal_sheaf(E))
end

I = ideal(S, [S[1], S[2]])
# Select variables corresponding to rays [1,0] and [0,1]
I = ideal(S, gens(S)[findall(v->v[1]>=0&&v[2]>=0, rays(P2))])
bl2 = blow_up(P2, I)
II = IdealSheaf(P2, I)

Expand Down
Loading