Resolve unbound type parameters #4363
Open
+31
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes some of the ambiguities for direct_product, direct_sum, tensor_product with empty argument list. Re-enable Aqua test for unbound type parameters.
joschmitt
reviewed
Nov 28, 2024
lgoettgens
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Missing docstring for
direct_sum(M::ModuleFP{T}...; task::Symbol = :sum) where T. Check Documenter's build log for details.' in@docsblock in src/CommutativeAlgebra/ModulesOverMultivariateRings/module_operations.md:29-31
I think you need to update the docstring signature at this place as well
| function direct_product(M::ModuleFP{T}, Ms::ModuleFP{T}...; task::Symbol = :prod) where T | ||
| return direct_product([M, Ms...]; task) | ||
| end | ||
| function direct_product(M::Vector{<:ModuleFP{T}}; task::Symbol = :prod) where T | ||
| F, pro, mF = direct_product([ambient_free_module(x) for x = M]..., task = :both) |
There was a problem hiding this comment.
Suggested change
| F, pro, mF = direct_product([ambient_free_module(x) for x = M]..., task = :both) | |
| F, pro, mF = direct_product([ambient_free_module(x) for x = M], task = :both) |
Better to not splat here, but use the new method taking a vector
There was a problem hiding this comment.
I wasn't sure if this is indeed now available in all possible cases that could occur here.
Co-authored-by: Lars Göttgens <[email protected]>
joschmitt
reviewed
Nov 28, 2024
joschmitt
reviewed
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes some of the ambiguities for direct_product,
direct_sum, tensor_product with empty argument list.
Re-enable Aqua test for unbound type parameters.