Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve unbound type parameters #4363

Merged
merged 10 commits into from
Jan 15, 2025
Merged

Resolve unbound type parameters #4363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e67e2d4
Resolve unbound type parameters
fingolfin Nov 28, 2024
0b2864c
Update src/Modules/UngradedModules/DirectSum.jl
joschmitt Nov 28, 2024
921775a
Apply suggestions from code review
fingolfin Nov 28, 2024
372b085
docs
fingolfin Nov 28, 2024
7ff87de
Handle abstract type
joschmitt Nov 28, 2024
1780646
Fix default values
joschmitt Nov 28, 2024
ecb22dd
fixes
fingolfin Nov 28, 2024
07892ed
Update src/Modules/UngradedModules/DirectSum.jl
fingolfin Jan 15, 2025
67170ad
cleanup
fingolfin Jan 15, 2025
9b802ac
update docstring
fingolfin Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/src/CommutativeAlgebra/ModulesOverMultivariateRings/module_operations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ cokernel(a::ModuleFPHom)
## Direct Sums and Products

```@docs
direct_sum(M::ModuleFP{T}...; task::Symbol = :sum) where T
direct_sum(M::ModuleFP{T}, Ms::ModuleFP{T}...; task::Symbol = :sum) where T
```

```@docs
direct_product(M::ModuleFP{T}...; task::Symbol = :prod) where T
direct_product(M::ModuleFP{T}, Ms::ModuleFP{T}...; task::Symbol = :prod) where T
```

## Truncation
Expand Down
14 changes: 6 additions & 8 deletions experimental/DoubleAndHyperComplexes/src/Objects/tensor_products.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,14 +353,12 @@
return HCTensorProductComplex(factors)
end

function tensor_product(c::AbsHyperComplex...)
return tensor_product(collect(c))
function tensor_product(c::AbsHyperComplex, cs::AbsHyperComplex...)
return tensor_product([c, cs...])
end

function tensor_product(M::ModuleFP{T}...) where {U<:MPolyComplementOfPrimeIdeal, T<:MPolyLocRingElem{<:Any, <:Any, <:Any, <:Any, U}}
R = base_ring(first(M))
@assert all(N->base_ring(N)===R, M) "modules must be defined over the same ring"
return tensor_product([free_resolution(SimpleFreeResolution, N)[1] for N in M]...)
function tensor_product(M::ModuleFP{T}, Ms::ModuleFP{T}...) where {U<:MPolyComplementOfPrimeIdeal, T<:MPolyLocRingElem{<:Any, <:Any, <:Any, <:Any, U}}
R = base_ring(M)
@assert all(N->base_ring(N)===R, Ms) "modules must be defined over the same ring"
return tensor_product([free_resolution(SimpleFreeResolution, N)[1] for N in (M, Ms...)])

Check warning on line 363 in experimental/DoubleAndHyperComplexes/src/Objects/tensor_products.jl

View check run for this annotation

Codecov / codecov/patch

experimental/DoubleAndHyperComplexes/src/Objects/tensor_products.jl#L360-L363 

Added lines #L360 - L363 were not covered by tests
end


14 changes: 10 additions & 4 deletions experimental/GModule/src/Cohomology.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ using Oscar
import Oscar: action
import Oscar: induce
import Oscar: word
import Oscar: GAPWrap, pc_group, fp_group, direct_product, direct_sum
import AbstractAlgebra: Group, Module
import Oscar: GAPWrap, pc_group, fp_group, direct_product, direct_sum, GAPGroup
import AbstractAlgebra: Group, Module, FPModule
import Base: parent

import Oscar: pretty, Lowercase, @show_name, @show_special
Expand Down Expand Up @@ -444,7 +444,10 @@ function Oscar.tensor_product(C::GModule{<:Any, FinGenAbGroup}...; task::Symbol
end
end

function Oscar.tensor_product(C::GModule{S, <:AbstractAlgebra.FPModule{<:Any}}...; task::Symbol = :map) where S <: Oscar.GAPGroup
function Oscar.tensor_product(C::GModule{T, <:FPModule}, Cs::GModule{T, <:FPModule}...; task::Symbol = :map) where {T <: GAPGroup}
return Oscar.tensor_product(GModule{T, <:FPModule}[C, Cs...]; task)
end
function Oscar.tensor_product(C::Vector{<:GModule{<:GAPGroup, <:FPModule}}; task::Symbol = :map)
@assert all(x->x.G == C[1].G, C)
@assert all(x->base_ring(x) == base_ring(C[1]), C)

Expand All @@ -463,7 +466,10 @@ import Hecke.⊗
⊗(C::GModule...) = Oscar.tensor_product(C...; task = :none)


function Oscar.tensor_product(F::AbstractAlgebra.FPModule{T}...; task = :none) where {T}
function Oscar.tensor_product(F::FPModule{T}, Fs::FPModule{T}...; task = :none) where {T}
return Oscar.tensor_product([F, Fs...]; task)
end
function Oscar.tensor_product(F::Vector{<:FPModule{T}}; task = :none) where {T}
@assert all(x->base_ring(x) == base_ring(F[1]), F)
d = prod(dim(x) for x = F)
G = free_module(base_ring(F[1]), d)
Expand Down
4 changes: 2 additions & 2 deletions src/AlgebraicGeometry/Schemes/Sheaves/CoherentSheaves.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,8 +574,8 @@ Coherent sheaf of modules
1: [(y//x)] affine 1-space
2: [(x//y)] affine 1-space
with restrictions
1: direct sum of (Multivariate polynomial ring in 1 variable over GF(7)^1, Multivariate polynomial ring in 1 variable over GF(7)^1)
2: direct sum of (Multivariate polynomial ring in 1 variable over GF(7)^1, Multivariate polynomial ring in 1 variable over GF(7)^1)
1: direct sum of FreeMod{FqMPolyRingElem}[Multivariate polynomial ring in 1 variable over GF(7)^1, Multivariate polynomial ring in 1 variable over GF(7)^1]
2: direct sum of FreeMod{FqMPolyRingElem}[Multivariate polynomial ring in 1 variable over GF(7)^1, Multivariate polynomial ring in 1 variable over GF(7)^1]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changed docstring is caused by the attribute direct_product changing from a Tuple to a Vector, and it gets printed raw by this function:

function Hecke.show_direct_sum(io::IO, G)
  D = get_attribute(G, :direct_product)
  D === nothing && error("only for direct sums")
  print(io, "direct sum of ")
  show(IOContext(io, :compact => true), D)
end

For nicer printing, that function (and its siblings around it) should be improved.

That leave the question whether the change from tuple to vector is fine. I had a quick look at the code using this attribute and I believe it is all fine either. Long term a vector IMO makes more sense there.

CC @HechtiDerLachs


julia> typeof(W)
DirectSumSheaf{CoveredScheme{FqField}, AbsAffineScheme, ModuleFP, Map}
Expand Down
20 changes: 15 additions & 5 deletions src/Modules/UngradedModules/DirectSum.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,12 @@ Additionally, return
- two vectors containing the canonical projections and injections, respectively, if `task = :both`,
- none of the above maps if `task = :none`.
"""
function direct_product(F::FreeMod{T}...; task::Symbol = :prod) where {T}
function direct_product(M::FreeMod{T}, Ms::FreeMod{T}...; task::Symbol = :prod) where T
return direct_product([M, Ms...]; task)
end
function direct_product(F::Vector{<:FreeMod{T}}; task::Symbol = :prod) where T
R = base_ring(F[1])
G = FreeMod(R, sum([rank(f) for f = F]))
G = FreeMod(R, sum(rank, F))
all_graded = all(is_graded, F)
if all_graded
G.d = vcat([f.d for f in F]...)
Expand Down Expand Up @@ -70,8 +73,11 @@ Additionally, return
- two vectors containing the canonical projections and injections, respectively, if `task = :both`,
- none of the above maps if `task = :none`.
"""
function direct_product(M::ModuleFP{T}...; task::Symbol = :prod) where T
F, pro, mF = direct_product([ambient_free_module(x) for x = M]..., task = :both)
function direct_product(M::ModuleFP{T}, Ms::ModuleFP{T}...; task::Symbol = :prod) where T
return direct_product([M, Ms...]; task)
end
function direct_product(M::Vector{<:ModuleFP{T}}; task::Symbol = :prod) where T
F, pro, mF = direct_product([ambient_free_module(x) for x = M], task = :both)
s, emb_sF = sub(F, vcat([elem_type(F)[mF[i](y) for y = ambient_representatives_generators(M[i])] for i=1:length(M)]...))
q::Vector{elem_type(F)} = vcat([elem_type(F)[mF[i](y) for y = rels(M[i])] for i=1:length(M)]...)
pro_quo = nothing
Expand Down Expand Up @@ -127,6 +133,7 @@ function direct_product(M::ModuleFP{T}...; task::Symbol = :prod) where T
end
end
end

##################################################
# direct sum
##################################################
Expand All @@ -141,7 +148,10 @@ Additionally, return
- two vectors containing the canonical injections and projections, respectively, if `task = :both`,
- none of the above maps if `task = :none`.
"""
function direct_sum(M::ModuleFP{T}...; task::Symbol = :sum) where {T}
function direct_sum(M::ModuleFP{T}, Ms::ModuleFP{T}...; task::Symbol = :sum) where T
return direct_sum([M, Ms...]; task)
end
function direct_sum(M::Vector{<:ModuleFP{T}}; task::Symbol = :sum) where T
res = direct_product(M...; task)
if task == :sum || task == :prod
ds, f = res
Expand Down
2 changes: 0 additions & 2 deletions test/Aqua.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@ using Aqua
Aqua.test_all(
Oscar;
ambiguities=false, # TODO: fix ambiguities
unbound_args=false, # TODO: fix unbound type parameters
piracies=false, # TODO: check the reported methods to be moved upstream
# Aqua persistent task does not work properly with developed dependencies
# thus we disable these tests when running in OscarCI:
persistent_tasks=!haskey(ENV, "oscar_run_tests"),
)
@test length(Aqua.detect_unbound_args_recursively(Oscar)) <= 16
end
Loading