-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LieAlgebras: Adapt Demazure operator #4384
LieAlgebras: Adapt Demazure operator #4384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments below. Please also add the new docstrings (2 reflect, 2 reflect!, 1 reflection) to the corresponding documentation pages (in experimental/LieAlgebras/docs/src/root_systems.md
or weight_lattice.md
.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4384 +/- ##
==========================================
- Coverage 84.38% 84.38% -0.01%
==========================================
Files 658 663 +5
Lines 87157 87934 +777
==========================================
+ Hits 73551 74199 +648
- Misses 13606 13735 +129
|
1ed6abb
to
a24a468
Compare
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
44603b9
to
a3871cd
Compare
05c5da3
to
422ed18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my POV, thanks! But it would be great to hear the opinion of @felix-roehrich as well.
demazure_operator(r::RootSpaceElem, w::WeightLatticeElem) -> Dict{WeightLatticeElem,<:IntegerUnion} | ||
demazure_operator(r::RootSpaceElem, groupringelem::Dict{WeightLatticeElem,<:IntegerUnion}) -> Dict{WeightLatticeElem,<:IntegerUnion} | ||
|
||
Computes the action of the Demazure operator associated to the positive root `r` on the given element of the groupring $\mathbb{Z}[P]$. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Computes the action of the Demazure operator associated to the positive root `r` on the given element of the groupring $\mathbb{Z}[P]$. | |
Computes the action of the Demazure operator associated to the positive root `r` on the given element of the group ring $\mathbb{Z}[P]$. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(it would be far preferable if the input was an actual group ring element, but this may not currently be an option... though my understanding is that recently some code for this (group rings over larger groups via dices) has been added to Hecke by @thofma ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some tinkering with group algebras over the weight lattice (as an additive group) to represent characters a few weeks ago. This is indeed the preferred goal, but I wasn't satisfied with the usability of these objects yet (this is the main reason why these things are still in experimental).
This would be something I or @janikapeters could look into at some point in the future, and upstream all necessary improvements to Hecke. And if we then are satisfied with the result, we can convert both the input here and the outputs of all character-like functions.
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Max Horn <[email protected]>
223a390
to
113d2d9
Compare
Implemented by the request of @lgoettgens and @gfourier.
See the commit messages for details.
Currently this is based on #4399 and I will rebase it once this is merged