-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TropicalGeometry: tropical linear spaces from graphs #4445
base: master
Are you sure you want to change the base?
Conversation
@ollieclarke8787 Would you be able to review this pull request? |
274f8c2
to
b86b6a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4445 +/- ##
=======================================
Coverage 84.55% 84.55%
=======================================
Files 672 672
Lines 88880 88886 +6
=======================================
+ Hits 75152 75158 +6
Misses 13728 13728
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code correctly produces Bergman fan of the cycle matroid the graph. The example of K_3 is also correct.
bcd1d94
to
69551de
Compare
69551de
to
9079fd8
Compare
@benlorenz I've changed
However, it creates a bunch of errors in the type tests that I don't know how to fix: Can you please look into it when you have the time (most likely not during the currently ongoing polymake developer meeting)? Many thanks in advance! |
This pull requests adds a new constructor for tropical linear spaces from graphs. Useful (for me) for example for graph rigidity questions (see e.g. here).