Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TropicalGeometry: tropical linear spaces from graphs #4445

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YueRen
Copy link
Member

@YueRen YueRen commented Jan 10, 2025

This pull requests adds a new constructor for tropical linear spaces from graphs. Useful (for me) for example for graph rigidity questions (see e.g. here).

@YueRen
Copy link
Member Author

YueRen commented Jan 10, 2025

@ollieclarke8787 Would you be able to review this pull request?

@YueRen YueRen changed the title new: tropical_linear_space for graphs TropicalGeometry: tropical linear spaces from graphs Jan 10, 2025
@YueRen YueRen force-pushed the yr/TropicalLinearSpace branch from 274f8c2 to b86b6a1 Compare January 10, 2025 14:13
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.55%. Comparing base (3e86180) to head (9079fd8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4445   +/-   ##
=======================================
  Coverage   84.55%   84.55%           
=======================================
  Files         672      672           
  Lines       88880    88886    +6     
=======================================
+ Hits        75152    75158    +6     
  Misses      13728    13728           
Files with missing lines Coverage Δ
src/TropicalGeometry/linear_space.jl 81.87% <100.00%> (+0.76%) ⬆️

... and 2 files with indirect coverage changes

Copy link

@ollieclarke8787 ollieclarke8787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code correctly produces Bergman fan of the cycle matroid the graph. The example of K_3 is also correct.

@YueRen YueRen force-pushed the yr/TropicalLinearSpace branch 3 times, most recently from bcd1d94 to 69551de Compare January 17, 2025 15:03
@YueRen YueRen force-pushed the yr/TropicalLinearSpace branch from 69551de to 9079fd8 Compare January 24, 2025 08:52
@YueRen
Copy link
Member Author

YueRen commented Jan 24, 2025

@benlorenz I've changed scalar_types_extended:

-const scalar_types_extended = Union{scalar_types,ZZRingElem}
+const scalar_types_extended = Union{scalar_types,IntegerUnion}

However, it creates a bunch of errors in the type tests that I don't know how to fix:
https://github.com/oscar-system/Oscar.jl/actions/runs/12946690999/job/36111735653?pr=4444#step:8:746

Can you please look into it when you have the time (most likely not during the currently ongoing polymake developer meeting)? Many thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants