-
Notifications
You must be signed in to change notification settings - Fork 140
Add tropical linear spaces from graphs #4445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
micjoswig
merged 12 commits into
oscar-system:master
from
YueRen:yr/TropicalLinearSpace
Mar 19, 2025
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9079fd8
TropicalGeometry: tropical_linear_space from graphs
YueRen b5c7e9e
Update src/TropicalGeometry/linear_space.jl
YueRen b117263
TropicalGeometry: changed docstring to indicate optional TropicalSemi…
YueRen 8d0ff08
TropicalGeometry: added default tropical_semiring_map for consistency
YueRen eca2d9f
TropicalGeometry: changed linear space docu
YueRen 96f32cb
TropicalGeometry: streamlined default TropicalSemiringMap declarations
YueRen f9ae479
TropicalGeometry: improved tropical_matrix
YueRen 17870e4
TropicalGeometry: updated tropical_linear_space test
YueRen f9f5ade
TropicalGeometry: fixed variable naming
YueRen a7a7437
TropicalGeometry: compute algebraic matrix from algebraic ideal if no…
YueRen 1db19f5
TropicalGeometry: fixed typo in docs
YueRen 67a77f1
TropicalGeometry: added note on Bergman fans
YueRen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs on tropical linear spaces (and the rest of tropical geometry) need to state explicitly where the various objects (tropical varieties, tropical linear spaces etc) actually live. Candidates include R^n or the tropical projective torus R^n/R1 (in the homogeneous setting). Either there are choices for the user to make, or there are fixed global decisions.
Specifically, tropical linear spaces may also be viewed as tropical polytopes. And then there are more choices, for they can be considered in a tropical projective torus or in a tropical projective space. I guess, none of this is currently supported in OSCAR.
The role of Bergman fans and constant vs non-constant coefficients must be explained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, I will adjust the documentation accordingly.