feat(pci-kubernetes): enable region enabling on cluster #17192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
2 times, most recently
from
421735a to
cfdc64e
Compare
SimonChaumet
previously approved these changes
May 20, 2025
packages/manager/apps/pci-kubernetes/src/api/hooks/useRegions.ts
Outdated
Show resolved
Hide resolved
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
3 times, most recently
from
7c8e790 to
25f7bcc
Compare
| @@ -0,0 +1,39 @@ | |||
| import { fetchIcebergV6, v6 } from '@ovh-ux/manager-core-api'; | |||
|
|
|||
| export type TRegionType = 'region' | 'localzone' | 'region-3-az' | string; | |||
There was a problem hiding this comment.
Maybe we should think about reusing this in our common package
packages/manager/apps/pci-kubernetes/src/api/hooks/useAddRegion.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/api/hooks/useRegions.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/components/region-selector/RegionList.component.tsx
Outdated
Show resolved
Hide resolved
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
from
e8d8174 to
476d82f
Compare
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
2 times, most recently
from
973b340 to
2bee41a
Compare
Tsiorifamonjena
previously approved these changes
May 27, 2025
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
from
2bee41a to
0c5923a
Compare
github-actions
bot
added
universe-public-cloud
has conflicts
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
from
0c5923a to
0348bc8
Compare
|
There are comments still open |
ppprevost
commented
Jun 4, 2025
...ages/manager/apps/pci-kubernetes/src/components/region-selector/RegionSelector.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/pages/new/steps/LocationStep.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/components/region-selector/RegionList.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/components/region-selector/RegionList.component.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/api/hooks/useAddRegion.ts
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/src/pages/new/steps/LocationStep.component.tsx
Show resolved
Hide resolved
packages/manager/apps/pci-kubernetes/public/translations/region-selector/Messages_fr_FR.json
Outdated
Show resolved
Hide resolved
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
from
6faf6af to
a620c2a
Compare
SimonChaumet
previously approved these changes
Jun 4, 2025
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
from
7d47fd5 to
5079123
Compare
fredericvilcot
previously approved these changes
Jun 4, 2025
SimonChaumet
previously approved these changes
Jun 5, 2025
lionel95200x
previously approved these changes
Jun 11, 2025
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
from
5079123 to
bfd3769
Compare
ppprevost
dismissed stale reviews from lionel95200x, fredericvilcot, and SimonChaumet
via
1ccc27c
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
from
bfd3769 to
1ccc27c
Compare
ref: #TAPC-3439 Signed-off-by: Pierre-Philippe <[email protected]> Coauthored-by: CDS Translator Agent <[email protected]>
ppprevost
force-pushed
the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
from
ff5144d to
a0b1d92
Compare
fredericvilcot
requested review from
SimonChaumet,
lionel95200x and
fredericvilcot
fredericvilcot
approved these changes
Jun 13, 2025
SimonChaumet
approved these changes
Jun 13, 2025
Tsiorifamonjena
approved these changes
Jun 13, 2025
fredericvilcot
merged commit b9d8dac
into
prelease/public-cloud-w25
16 of 18 checks passed
fredericvilcot
deleted the
feat/pci-kubernetes_enable-cluster-region_tapc-3439
branch
This was referenced Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #TAPC-3439
Description
Ticket Reference: #...
Additional Information