improvement: Refactor req retrier/URI selection into new URISelector interface. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The components of the request retrier in CGR were tightly coupled and hard to reason about. Due to how requests are retried currently, we are unable to preserve server state across requests very easily.
After this PR
The URISelector interface allows for implementations of client side load balancing algorithms. For example, least used connection, server size error handling, rendezvous routing, zone aware routing, strict client side sharing, ect. Multiple URISelectors can be chained together in order to compound the client balancing that occurs.
==COMMIT_MSG==
Refactor req retrier/URI selection into new URISelector interface.
==COMMIT_MSG==
Feature branch replacement of: #341
Possible downsides?
This change is