TYP: Update Timedelta __init__ type hints to document it takes Tick objects #1640
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
requested changes
Jan 22, 2026
Collaborator
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
Please make these changes and then I will do the CI
Comment on lines
+113
to
+115
| tick = Minute(15) | ||
| seconds = pd.Timedelta(tick).total_seconds() | ||
| assert seconds == 900.0 |
Collaborator
There was a problem hiding this comment.
The test should be of the form:
check(assert_type(pd.Timedelta(Minute(15)), pd.Timedelta), pd.Timedelta)| from pandas._libs.tslibs import NaTType | ||
| from pandas._libs.tslibs import ( | ||
| NaTType, | ||
| Tick, |
Collaborator
There was a problem hiding this comment.
Should import Tick from pandas.tseries.offsets
| from typing_extensions import assert_type | ||
|
|
||
| from pandas._libs import NaTType | ||
| from pandas._libs.tslibs.offsets import Minute |
Collaborator
There was a problem hiding this comment.
Should import Minute from pandas.tseries.offsets
Collaborator
Yes, please!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to follow pandas-dev/pandas#55498, mypy complaines
The pandas source code checks if the
valueparameter is a Tick object (is_tick_object)This is my first PR to this project. Question to reviewers: Shall I also open a PR to the pandas main repo to update the docstring to improve the documentation?
assert_type()to assert the type of any return value)AGENTS.md.