-
-
Notifications
You must be signed in to change notification settings - Fork 160
TYP: Update Timedelta __init__ type hints to document it takes Tick objects #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gogowitsch
wants to merge
1
commit into
pandas-dev:main
Choose a base branch
from
Gogowitsch:Timedelta-constructor-takes-Tick-objects
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ | |
| from typing_extensions import assert_type | ||
|
|
||
| from pandas._libs import NaTType | ||
| from pandas._libs.tslibs.offsets import Minute | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should import |
||
| from pandas._libs.tslibs.timedeltas import Timedelta | ||
| from pandas._typing import TimeUnit | ||
|
|
||
|
|
@@ -107,6 +108,13 @@ def test_timedelta_array_mod() -> None: | |
| check(assert_type(result, TimedeltaArray), TimedeltaArray) | ||
|
|
||
|
|
||
| def test_timedelta_takes_tick_object() -> None: | ||
| """Test that Timedelta objects can be built using tick objects such as Minute.""" | ||
| tick = Minute(15) | ||
| seconds = pd.Timedelta(tick).total_seconds() | ||
| assert seconds == 900.0 | ||
|
Comment on lines
+113
to
+115
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The test should be of the form: check(assert_type(pd.Timedelta(Minute(15)), pd.Timedelta), pd.Timedelta) |
||
|
|
||
|
|
||
| def test_timedelta_array_divmod() -> None: | ||
| """Test __divmod__ for TimedeltaArray.""" | ||
| idx = pd.TimedeltaIndex(["1 days", "2 days", "3 days"]) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should import
Tickfrompandas.tseries.offsets