Skip to content

Use PANTHEON_HOSTNAME when setting SERVER_NAME #9478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use PANTHEON_HOSTNAME when setting SERVER_NAME #9478

wants to merge 3 commits into from

Conversation

rachelwhitton
Copy link
Member

@rachelwhitton rachelwhitton commented Mar 12, 2025 •
edited by jazzsequence
Loading

Fixes #9424

Summary

WordPress Plugins and Themes with Known Issues - Use PANTHEON_HOSTNAME when setting SERVER_NAME across all instances

$_SERVER['SERVER_NAME'] = PANTHEON_HOSTNAME;

@rachelwhitton rachelwhitton added the Type: Quick Fix Issues that should be resolvable in a small PR label Mar 12, 2025
@rachelwhitton rachelwhitton requested a review from dficker March 12, 2025 15:28
@rachelwhitton rachelwhitton self-assigned this Mar 12, 2025
@rachelwhitton rachelwhitton requested a review from a team as a code owner March 12, 2025 15:28
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9478-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@rachelwhitton
Copy link
Member Author

Reassigning to @jazzsequence to better understand the issue and it's relation to pantheon_hostname

@rachelwhitton rachelwhitton added Type: Fix Content Issue or PR to resolve incorrect information in the docs Topic: WordPress WordPress-specific Process: Needs SME Issue or PR that won't move forward without subject-matter expert contribution and removed Type: Quick Fix Issues that should be resolvable in a small PR labels Mar 19, 2025
@jazzsequence
Copy link
Contributor

Refactored recommendations to use PANTHEON_HOSTNAME in all cases.

See:

@jazzsequence jazzsequence changed the title Evaluate requests from the cli before setting SERVER_NAME Use PANTHEON_HOSTNAME when setting SERVER_NAME Apr 18, 2025
@jazzsequence jazzsequence mentioned this pull request Apr 18, 2025
Open
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9478-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9478-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazzsequence jazzsequence jazzsequence approved these changes

@dficker dficker Awaiting requested review from dficker

Assignees

@jazzsequence jazzsequence

Labels
Process: Needs SME Issue or PR that won't move forward without subject-matter expert contribution Topic: WordPress WordPress-specific Type: Fix Content Issue or PR to resolve incorrect information in the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WordPress Plugins and Themes with Known Issues Doc Update
2 participants
@rachelwhitton @jazzsequence