refactor(storage): extract shared find_changeset_block_from_index algorithm [1/3] #20542
+267
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add HistoryInfo enum with documentation and extract the shared rank/select algorithm into history_info_from_shard function. This prepares for RocksDB integration by making the history lookup algorithm reusable across different storage backends (MDBX, RocksDB). Changes: - Add HistoryInfo enum with detailed doc comments - Add history_info_from_shard function with the core algorithm - Refactor history_info method to use the shared function - Export HistoryInfo and history_info_from_shard from providers module
This was referenced Dec 21, 2025
yongkangc
changed the title
yongkangc
requested review from
gakonst,
joshieDo,
rakita and
shekhirin
as code owners
…_index The new name better describes the function's purpose: given a history index shard, find which changeset block contains the historical value for a target block. Also moved the function below the impl block for better code organization.
yongkangc
force-pushed
the
yk/pr1-history-info-abstraction
branch
from
6f8341e to
244c864
Compare
yongkangc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extract the history lookup algorithm into a reusable function that can be shared between MDBX and RocksDB backends.
This is PR 1/3 of a stacked PR series that splits #20412 for easier review. Closes #20388
Review focus
find_changeset_block_from_indexcorrectly captures the original algorithmHistoryInfovariants is accurateChanges
HistoryInfoenum with detailed documentation explaining each variantfind_changeset_block_from_index()function containing the core rank/select algorithmHistoricalStateProviderRef::history_info()to use the shared functionHistoryInfoandfind_changeset_block_from_indexfrom providers moduleStack