feat(storage): add RocksDB history lookup methods and owned batch type [2/3] #20543
+167
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongkangc
changed the title
yongkangc
force-pushed
the
yk/pr2-rocksdb-infrastructure
branch
from
e45acf9 to
40f84f2
Compare
Enhance RocksDB provider infrastructure for history lookups: - Change RocksDBBatch to own Arc<RocksDBProviderInner> instead of borrowing This allows storing RocksDBBatch in DatabaseProvider without lifetime issues. - Add RocksTx::account_history_info() and storage_history_info() methods These use the shared history_info_from_shard algorithm to lookup history in RocksDB with the same semantics as MDBX. - Update rocksdb_stub.rs with matching API (batch(), commit(), len(), is_empty()) This prepares the infrastructure for PR3 which will wire RocksDB into HistoricalStateProvider and DatabaseProvider HistoryWriter.
…_index in RocksDB
yongkangc
force-pushed
the
yk/pr2-rocksdb-infrastructure
branch
from
7b937ec to
9aefeba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RocksDB infrastructure for history lookups without changing any behavior.
This is PR 2/3 of a stacked PR series that splits #20412 for easier review. Closes #20388
Depends on: #20542
Review focus:
RocksTxhistory lookup methodsRocksDBBatchownership change is safeChanges
rocksdb/provider.rsRocksDBBatchto ownArc<RocksDBProviderInner>instead of borrowingRocksDBBatchinDatabaseProviderwithout lifetime issuesRocksTx::account_history_info()methodRocksTx::storage_history_info()methodhistory_info_from_shardalgorithm from PR1rocksdb_stub.rsRocksDBProvider::batch()stub methodRocksDBBatch::commit(),len(),is_empty()stub methodsStack