fix: dont filter out created+selfdestruct in pre #382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
|
I still have a question about the line: revm-inspectors/src/tracing/builder/geth.rs Lines 378 to 379 in cbf97c9 A contract can be deployed at an address with non-zero balance. If that happens (and it doesn't selfdestruct), the pre section should contain the address with only balance. IIUC, this line would still filter it out. Basically, the rule should be to filter out from pre contracts that have been deployed on empty addresses. I don't have an example to test on geth at hand, but should be easy enough to find one. |
Contributor
Author
|
right, I think this makes sense need to write a new test case for this scenario and look at the geth impl again |
Contributor
Author
|
superseded by #383 |
mattsse
added a commit
that referenced
this pull request
Nov 28, 2025
This aims at resolving issues mentioned in #382 , typically this one : <img width="1818" height="694" alt="image" src="https://github.com/user-attachments/assets/51b82944-c711-421b-8479-05095ae9bbce" /> To fix this , what i did was : - Keep track of addresses that are marked as Create and were truly empty in the database snapshot. Only these addresses are filtered from the prestate diff so prefunded contract deployments remain visible. - Introduce account_was_empty helper to avoid re-computing the emptiness check and add a regression test (prestate_diff_keeps_prefunded_created_accounts) that covers a prefunded creation vs. a true empty-address creation. cc @mattsse Please check it out if it resolves should close this one paradigmxyz/reth#19703 --------- Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close this one paradigmxyz/reth#19703
previously we were yeeting them from pre here:
revm-inspectors/src/tracing/builder/geth.rs
Lines 378 to 379 in cbf97c9