feat: Fix geth prestate filtering for prefunded creations #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Nov 28, 2025
Contributor
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
sorry for the delay, smol suggestion
src/tracing/builder/geth.rs
Outdated
Comment on lines
339
to
340
| if changed_acc.is_created() && account_was_empty(&db_acc) { | ||
| created_on_empty_accounts.insert(addr); |
Contributor
There was a problem hiding this comment.
isn't this equivalent to mapping to AccountChangeKind::Modify in this check
https://github.com/paradigmxyz/revm-inspectors/blob/main/src/tracing/builder/geth.rs#L328-L330
like we did in #382
then we don't need two maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims at resolving issues mentioned in #382 , typically this one :
To fix this , what i did was :
Keep track of addresses that are marked as Create and were truly empty in the database snapshot. Only these addresses are filtered from the prestate diff so prefunded contract deployments remain visible.
Introduce account_was_empty helper to avoid re-computing the emptiness check and add a regression test (prestate_diff_keeps_prefunded_created_accounts) that covers a prefunded creation vs. a true empty-address creation.
cc @mattsse Please check it out if it resolves
should close this one paradigmxyz/reth#19703