feat(typeck): implement constant folding for integer literal type preservation #649
+174
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…servation When both operands of a binary operation are IntLiteral, evaluate the expression at compile time to preserve literal type semantics. This allows expressions like `-(1 + 2)` to work correctly, since the result remains an IntLiteral that can be negated. Changes: - Extended IntScalar with explicit sign tracking and signed arithmetic - Added try_eval_int_literal_binop to evaluate literal binary expressions - Updated eval_array_len to reject negative array lengths
onbjerg
added
C-enhancement
This was referenced Dec 17, 2025
DaniPopes
requested changes
Dec 17, 2025
| BitXor => Self::new(self.data ^ r.data), | ||
| Shr => Self::new(self.data.wrapping_shr(r.data.try_into().unwrap_or(usize::MAX))), | ||
| Shl => Self::new(self.data.wrapping_shl(r.data.try_into().unwrap_or(usize::MAX))), | ||
| Sar => Self::new(self.data.arithmetic_shr(r.data.try_into().unwrap_or(usize::MAX))), |
Member
There was a problem hiding this comment.
this is >>> which only works on fixed types, we should rename this to sometihng so we dont forget its useless
| BitOr => Self::new(self.data | r.data), | ||
| BitAnd => Self::new(self.data & r.data), | ||
| BitXor => Self::new(self.data ^ r.data), | ||
| Shr => Self::new(self.data.wrapping_shr(r.data.try_into().unwrap_or(usize::MAX))), |
Member
There was a problem hiding this comment.
this should be arithmetic_shr depending on sign
| } | ||
|
|
||
| /// Returns whether the value is negative. | ||
| pub fn is_negative(&self) -> bool { |
Member
There was a problem hiding this comment.
this should probably be is_signed and be a constant value. then data should be I256 and is_negative will be I256's is_negative (last bit set). this way all ops are easier to keep track of, since they become regular two's complement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both operands of a binary operation are IntLiteral, evaluate the expression at compile time to preserve literal type semantics. This allows expressions like
-(1 + 2)to work correctly, since the result remains an IntLiteral that can be negated.Changes:
On top of #648
Stack: