Add support for vendor defined attributes #237
Conversation
Signed-off-by: Joe Rozner <[email protected]>
jrozner
force-pushed
the
add-vendor-defined-attributes
branch
from
ca4983b to
697a4bf
Compare
|
Does SoftHSM support them? Would be nice to add tests if possible. |
Signed-off-by: Joe Rozner <[email protected]>
Signed-off-by: Joe Rozner <[email protected]>
|
I'll look into whether SoftHSM supports any vendor defined attributes and can write some tests if it does. I've been testing this with a Yubikey which does rely on them for specifying the touch/pin policy. This set of changes seems to have broken something around the attribute type value, it's working with some values but not others. Need to debug. |
|
Looks like I just missed a compilation for my test code. Everything is working |
|
All good on my side! Seems that the CI is failing (can you see the logs btw? Could be a permission thing). Seems you need to |
Signed-off-by: Joe Rozner <[email protected]>
|
Formatting fixed |
cryptoki/src/object.rs
Outdated
| @@ -405,7 +413,6 @@ impl TryFrom<CK_ATTRIBUTE_TYPE> for AttributeType { | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone, PartialEq, Eq)] | |||
| #[non_exhaustive] | |||
There was a problem hiding this comment.
Why this got removed? Correct me if I'm wrong but vendor defined doesn't cover all space of possible values? 🤔
There was a problem hiding this comment.
Sorry, fixed that. You're correct that it's not exhaustive.
Head branch was pushed to by a user without write access
|
You forgot to sign-off the last commit 🍏 |
No description provided.